lang: programdata_address field for Program account #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-schaaf
commented
Dec 11, 2021
lang/src/program.rs
Outdated
| use solana_program::instruction::AccountMeta; | ||
| use solana_program::program_error::ProgramError; | ||
| use solana_program::pubkey::Pubkey; | ||
| use std::fmt; | ||
| use std::ops::Deref; | ||
|
|
||
| // TODO: can we remove _account? | ||
|
|
There was a problem hiding this comment.
is there any use to this field, considering that it's going to be empty struct all of the time
There was a problem hiding this comment.
Yes the type is needed for the id() function. Though a better way of doing might be with PhantomData. Can consider that for a separate PR though.
There was a problem hiding this comment.
yes that sounds better to me. #1140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.