Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: remove .spec from ts files #441

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Jun 30, 2021

I can be wrong, but can somebody explain to me why .spec required for TypeScript files?

@armaniferrante
Copy link
Member

armaniferrante commented Jun 30, 2021

The only reason it would be useful is if the testing framework needed to differentiate test files from regular modules. If this isn't the case, then removing is fine with me.

@fanatid
Copy link
Contributor Author

fanatid commented Jun 30, 2021

I'm not an expert in JS tests frameworks but as I understand *.spec.ts / *.test.ts / etc located with the source file which they test. tests directory do not need files with spec/test suffixes. Also, if we do not use TS, any js will be tested while with TS only *.spec.ts -- this does not look equal 🤔

@armaniferrante armaniferrante merged commit 94f08cd into coral-xyz:master Jun 30, 2021
@fanatid fanatid deleted the cli-remove-spec-suffix branch June 30, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants