Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): multi file question type #2040

Merged
merged 1 commit into from
Aug 5, 2022
Merged

(feat): multi file question type #2040

merged 1 commit into from
Aug 5, 2022

Conversation

derrabauke
Copy link
Contributor

@derrabauke derrabauke commented Jul 5, 2022 •
edited
Loading

This is the frontend part to this caluma PR which changes the file-question type to enable multiple file uploads. This leads to a series of changes around the graphql setup and the whole file handling procedure.

BREAKING CHANGE: This renames the question type constant for file questions,
and changes the semantics of the answer value for file questions as well:
It is now an array of objects instead of a string. The response type
for querying file(s) answers now also is a list.

For details / RFC see projectcaluma/caluma#1780

Design Preview:
fileupload_1

fileupload_2

@derrabauke derrabauke self-assigned this Jul 5, 2022
@derrabauke derrabauke force-pushed the feat-multi-file-question-type branch from aed8ca1 to f6703d6 Compare July 5, 2022 18:41
@anehx anehx mentioned this pull request Jul 6, 2022
Closed
@derrabauke derrabauke force-pushed the feat-multi-file-question-type branch 3 times, most recently from 9afb2a0 to fa989c7 Compare July 6, 2022 15:14
This was referenced Jul 7, 2022
Open
Closed
@derrabauke derrabauke force-pushed the feat-multi-file-question-type branch 2 times, most recently from 9eff384 to a501db5 Compare July 8, 2022 11:45
@winged winged mentioned this pull request Jul 13, 2022
Merged
@derrabauke derrabauke marked this pull request as ready for review July 26, 2022 16:44
anehx
anehx requested changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@anehx anehx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some fixes for consistency and readability but otherwise LGTM. Could you add a screenshot (especially of the new file list). Please also change the commit messages - currently this won't even trigger a release..

packages/form-builder/translations/de.yaml Outdated Show resolved Hide resolved
packages/form-builder/translations/en.yaml Outdated Show resolved Hide resolved
packages/form-builder/translations/fr.yaml Outdated Show resolved Hide resolved
packages/form/addon/components/cf-field-value.hbs Outdated Show resolved Hide resolved
packages/form/addon/components/cf-field/input.js Outdated Show resolved Hide resolved
packages/form/addon/components/cf-field/input/file.hbs Outdated Show resolved Hide resolved
packages/form/addon/components/cf-field/input/file.js Outdated Show resolved Hide resolved
packages/form/addon/components/cf-field/input/file.js Outdated Show resolved Hide resolved
packages/form/addon/components/cf-field/input/file.js Outdated Show resolved Hide resolved
@derrabauke derrabauke force-pushed the feat-multi-file-question-type branch from 0c1bab7 to ed16004 Compare August 3, 2022 08:28
@derrabauke derrabauke force-pushed the feat-multi-file-question-type branch 3 times, most recently from 4dff462 to 7640904 Compare August 3, 2022 15:52
@derrabauke derrabauke force-pushed the feat-multi-file-question-type branch 2 times, most recently from 19970d1 to 5ab7153 Compare August 4, 2022 09:53
czosel
czosel approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Looks good!

@derrabauke derrabauke force-pushed the feat-multi-file-question-type branch from 5ab7153 to f7387f1 Compare August 4, 2022 10:02
@derrabauke derrabauke force-pushed the feat-multi-file-question-type branch from f7387f1 to 48db5ac Compare August 4, 2022 10:51
@derrabauke
feat!: add multi file upload
f164312 
This replaces the single file upload and will enable the user to upload
multiple files at once.

BREAKING CHANGE: This requires the caluma backend version v8.0.0-beta.12
or later.
@derrabauke derrabauke force-pushed the feat-multi-file-question-type branch from 48db5ac to f164312 Compare August 4, 2022 11:29
@derrabauke derrabauke merged commit c4fd004 into projectcaluma:main Aug 5, 2022
anehx pushed a commit that referenced this pull request Aug 5, 2022
@semantic-release-bot
chore(release): 11.0.0-beta.10 [skip ci]
19681fa 
# [@projectcaluma/ember-testing-v11.0.0-beta.10](https://github.com/projectcaluma/ember-caluma/compare/@projectcaluma/ember-testing-v11.0.0-beta.9...@projectcaluma/ember-testing-v11.0.0-beta.10) (2022-08-05)

* feat!: add multi file upload (#2040) ([c4fd004](c4fd004)), closes [#2040](#2040)

### BREAKING CHANGES

* This requires the caluma backend version v8.0.0-beta.12
or later.
@anehx
Copy link
Contributor

anehx commented Aug 5, 2022

🎉 This PR is included in version @projectcaluma/ember-testing-v11.0.0-beta.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

anehx pushed a commit that referenced this pull request Aug 5, 2022
@semantic-release-bot
chore(release): 11.0.0-beta.9 [skip ci]
71488a9 
# [@projectcaluma/ember-core-v11.0.0-beta.9](https://github.com/projectcaluma/ember-caluma/compare/@projectcaluma/ember-core-v11.0.0-beta.8...@projectcaluma/ember-core-v11.0.0-beta.9) (2022-08-05)

* feat!: add multi file upload (#2040) ([c4fd004](c4fd004)), closes [#2040](#2040)

### BREAKING CHANGES

* This requires the caluma backend version v8.0.0-beta.12
or later.
@anehx
Copy link
Contributor

anehx commented Aug 5, 2022

🎉 This PR is included in version @projectcaluma/ember-core-v11.0.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

anehx pushed a commit that referenced this pull request Aug 5, 2022
@semantic-release-bot
chore(release): 11.0.0-beta.22 [skip ci]
8a8f3b3 
# [@projectcaluma/ember-form-v11.0.0-beta.22](https://github.com/projectcaluma/ember-caluma/compare/@projectcaluma/ember-form-v11.0.0-beta.21...@projectcaluma/ember-form-v11.0.0-beta.22) (2022-08-05)

* feat!: add multi file upload (#2040) ([c4fd004](c4fd004)), closes [#2040](#2040)

### BREAKING CHANGES

* This requires the caluma backend version v8.0.0-beta.12
or later.
@derrabauke derrabauke deleted the feat-multi-file-question-type branch August 5, 2022 07:35
@anehx
Copy link
Contributor

anehx commented Aug 5, 2022

🎉 This PR is included in version @projectcaluma/ember-form-v11.0.0-beta.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

anehx pushed a commit that referenced this pull request Aug 5, 2022
@semantic-release-bot
chore(release): 11.0.0-beta.16 [skip ci]
0e81216 
# [@projectcaluma/ember-form-builder-v11.0.0-beta.16](https://github.com/projectcaluma/ember-caluma/compare/@projectcaluma/ember-form-builder-v11.0.0-beta.15...@projectcaluma/ember-form-builder-v11.0.0-beta.16) (2022-08-05)

* feat!: add multi file upload (#2040) ([c4fd004](c4fd004)), closes [#2040](#2040)

### BREAKING CHANGES

* This requires the caluma backend version v8.0.0-beta.12
or later.
@anehx
Copy link
Contributor

anehx commented Aug 5, 2022

🎉 This PR is included in version @projectcaluma/ember-form-builder-v11.0.0-beta.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anehx anehx anehx requested changes

@czosel czosel czosel approved these changes

Assignees

@derrabauke derrabauke

Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabauke @anehx @czosel