Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FDS #1039

Closed
1 of 2 tasks
davecheney opened this issue Apr 23, 2019 · 5 comments
Closed
1 of 2 tasks

Add support for FDS #1039

davecheney opened this issue Apr 23, 2019 · 5 comments
Labels
blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. blocked/needs-envoy Categorizes the issue or PR as blocked because it needs changes in Envoy. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@davecheney
Copy link
Contributor

davecheney commented Apr 23, 2019 •
edited by youngnick
Loading

Currently any change to the TLS listener requires updating the ingress_https LDS entry. Updating this entry will cause the previous listener definition to move into draining mode for --drain-time-s (default, 10 min) time. During that time listener structs sit around in memory. After that time any connections established via a draining listener are forcibly closed.

The solution to this upstream is FDS, a new xDS endpoint that will serve FilterChain configuration -- the magic that makes the TLS listener work with SNI -- and remove the need to reload the object that holds the TLS socket.

Blocked:
@davecheney davecheney added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. blocked Blocked waiting on a dependency labels Apr 23, 2019
@davecheney davecheney mentioned this issue Apr 23, 2019
Closed
@davecheney davecheney added this to the 1.0.0.beta.1 milestone Jun 18, 2019
@davecheney
Copy link
Contributor Author

Without support for FDS in Envoy 1.11 we cannot work on this in beta.1

@davecheney davecheney modified the milestones: 1.0.0-beta.1, 1.0.0-rc.1 Aug 23, 2019
@davecheney davecheney modified the milestones: 1.0.0-rc.1, Backlog Sep 10, 2019
@davecheney
Copy link
Contributor Author

Moved to the backlog. Contour 1.0.0 will ship with Envoy 1.11. We will revisit this issue when a version of Envoy with FDS is available.

@davecheney
Copy link
Contributor Author

It looks like FDS will require Envoy 1.12 and possibly a switch to XDS's v3 api. envoyproxy/envoy#4540

@jpeach jpeach added blocked/needs-envoy Categorizes the issue or PR as blocked because it needs changes in Envoy. and removed blocked Blocked waiting on a dependency labels Apr 30, 2020
@sunjayBhatia sunjayBhatia added blocked/needs-envoy Categorizes the issue or PR as blocked because it needs changes in Envoy. and removed blocked/needs-envoy Categorizes the issue or PR as blocked because it needs changes in Envoy. labels Dec 14, 2021
@skriss skriss removed this from the Backlog milestone Jul 25, 2022
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2024
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. blocked/needs-envoy Categorizes the issue or PR as blocked because it needs changes in Envoy. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davecheney @jpeach @skriss @sunjayBhatia