Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keepalives to Contour's gRPC serving #1756

Closed
youngnick opened this issue Oct 22, 2019 · 1 comment
Closed

Add Keepalives to Contour's gRPC serving #1756

youngnick opened this issue Oct 22, 2019 · 1 comment
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@youngnick
Copy link
Member

youngnick commented Oct 22, 2019

In addition to #1744, adding TCP keepalives to Envoy, we need to add some form of keepalive to the Contour -> Envoy communication, to detect dead connections and prune them.

Initial investigation:

It doesn't really seem a good idea to mess with the TCP keepalive settings on the server side, as that's a property of the connection, not of the server (it seems).

Looks like we can add gRPC keepalives pretty easily since we already have a way to add extra server options to the gRPC listener. There's two parameters we really need to set, here are my suggestions about default values:

  • Time (how long to wait before attempting a ping): 1 minute (This is an idle timer)
  • Timeout (how long to wait before considering the connection dead: 20s (default, seems reasonable).
@youngnick youngnick added this to the 1.0.0-rc.2 milestone Oct 22, 2019
@youngnick youngnick added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 22, 2019
@youngnick youngnick self-assigned this Oct 22, 2019
@youngnick
Copy link
Member Author

Closed by #1758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

1 participant