Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Show P99 latency in envoy dashboards #190

Closed
alexbrand opened this issue Jul 25, 2018 · 5 comments
Closed

Show P99 latency in envoy dashboards #190

alexbrand opened this issue Jul 25, 2018 · 5 comments
Assignees
@stevesloka
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. monitoring priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.3-beta.2

Comments

@alexbrand
Copy link
Contributor

The current dashboards show P90 latency. We should either update that to display P99, or add an additional line that charts P99 latencies.
@alexbrand alexbrand added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. monitoring labels Jul 25, 2018
@rosskukulinski rosskukulinski added this to the v0.3-beta.2 milestone Jul 25, 2018
@rosskukulinski rosskukulinski self-assigned this Jul 25, 2018
@stevesloka stevesloka mentioned this issue Jul 25, 2018
Merged
@rosskukulinski
Copy link
Contributor

Fixed in #189

@alexbrand
Copy link
Contributor Author

I am reopening this as I am only seeing P99 for upstream latencies, but not downstream latencies. Pinging @stevesloka to make sure I am not crazy, and confirm his change only modified the upstream latencies panel.

@alexbrand alexbrand reopened this Jul 31, 2018
@stevesloka
Copy link
Member

Bah yeah, I only did for upstream. I think maybe I misunderstood, can update to fix.

@alexbrand
Copy link
Contributor Author

Sounds good @stevesloka. Assigning to you, but happy to take it if you're busy.

@stevesloka stevesloka mentioned this issue Aug 9, 2018
Merged
@stevesloka
Copy link
Member

@alexbrand I added the P99 to the Downstream panel.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stevesloka stevesloka

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. monitoring priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.3-beta.2
Development

No branches or pull requests
3 participants
@alexbrand @stevesloka @rosskukulinski