Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Access to Source Statistics When Using Subfinder as a library #1237

Closed
meme-lord opened this issue Apr 27, 2024 · 0 comments · Fixed by #1238
Closed

Provide Access to Source Statistics When Using Subfinder as a library #1237

meme-lord opened this issue Apr 27, 2024 · 0 comments · Fixed by #1238
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@meme-lord
Copy link
Contributor

Please describe your feature request:

I would like to be able to access the statistics of sources from the passive agent GetStatistics function. The passive agent isnt accessible from the runner because the name in the struct starts with a lowercase letter which makes it only accessible within the package.

I can think of three possible solutions:

  1. Make the passiveAgent accessible by changing the struct.
  2. Making a new function in the runner that returns the source statistics from the agent
  3. I have to implement my own runner. I don't think this requires any changes to the repo but it does feel like I will be reinventing the wheel a bit here

Describe the use case of this feature:

To be able to monitor errors from sources and raise a log message from my automation as well as disabling sources that have errored out, ran out of credits or blocked me.

@meme-lord meme-lord added the Type: Enhancement Most issues will probably ask for additions or changes. label Apr 27, 2024
@dogancanbakir dogancanbakir linked a pull request Apr 28, 2024 that will close this issue
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants