Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix errorutil import #161

Closed
tarunKoyalwar opened this issue Jan 19, 2023 · 1 comment · Fixed by #162
Closed

fix errorutil import #161

tarunKoyalwar opened this issue Jan 19, 2023 · 1 comment · Fixed by #162
Assignees
@tarunKoyalwar
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
tlsx v1.0.5

Comments

@tarunKoyalwar
Copy link
Member

tlsx version:

dev | main

Current Behavior:

  • type Error is incorrectly imported from go-errors instead of utils/errors which causes build and lint failure
@tarunKoyalwar tarunKoyalwar added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 19, 2023
@tarunKoyalwar
Copy link
Member Author 

# github.com/projectdiscovery/tlsx/pkg/tlsx/openssl
/Users/tarun/go/pkg/mod/github.com/projectdiscovery/tlsx@v1.0.4/pkg/tlsx/openssl/utils.go:7:2: imported and not used: "github.com/projectdiscovery/utils/errors" as errorutil
/Users/tarun/go/pkg/mod/github.com/projectdiscovery/tlsx@v1.0.4/pkg/tlsx/openssl/utils.go:46:16: undefined: errors

@tarunKoyalwar tarunKoyalwar self-assigned this Jan 19, 2023
@tarunKoyalwar tarunKoyalwar mentioned this issue Jan 19, 2023
Merged
@tarunKoyalwar tarunKoyalwar linked a pull request Jan 19, 2023 that will close this issue
fix errorutil import #162
Merged
@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Jan 19, 2023
@ehsandeep ehsandeep added this to the tlsx v1.0.5 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarunKoyalwar tarunKoyalwar

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
tlsx v1.0.5
Development

Successfully merging a pull request may close this issue.

fix errorutil import projectdiscovery/tlsx
3 participants
@ehsandeep @Mzack9999 @tarunKoyalwar