Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mutex on read #176

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Adding mutex on read #176

merged 2 commits into from
Jun 13, 2023

Conversation

Mzack9999
Copy link
Member

This PR attempts to avoid concurrent read during internal buffer reset grow

Potentially closes projectdiscovery/nuclei#3797

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 12, 2023
@Mzack9999 Mzack9999 self-assigned this Jun 12, 2023
tarunKoyalwar
tarunKoyalwar approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep merged commit 347774d into main Jun 13, 2023
@ehsandeep ehsandeep deleted the bugfix-concurrent-reset-read branch June 13, 2023 11:39
@ehsandeep ehsandeep mentioned this pull request Jun 13, 2023
Closed
This was referenced Jun 22, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: runtime error: slice bounds out of range
3 participants
@Mzack9999 @tarunKoyalwar @ehsandeep