Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple consecutive Junk entries should be allowed #248

Closed
stasm opened this issue Jul 11, 2018 · 1 comment
Closed

Multiple consecutive Junk entries should be allowed #248

stasm opened this issue Jul 11, 2018 · 1 comment
Labels
fluent-syntax

Comments

@stasm
Copy link
Contributor

stasm commented Jul 11, 2018 •
edited
Loading

According to the spec, Junk should only be parsed up until the next valid entry start or a blank line. This effectively allows multiple consecutive Junk entries separated by blank lines.
@stasm stasm mentioned this issue Jul 11, 2018
Closed
@stasm stasm mentioned this issue Oct 19, 2018
Closed
@stasm
Copy link
Contributor Author

stasm commented Nov 13, 2018

We changed the spec in projectfluent/fluent#211 so that the blank line doesn't end junks.

@stasm stasm closed this as completed Nov 13, 2018
@Pike Pike mentioned this issue Sep 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fluent-syntax
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

End junk on blank lines to produce smaller Junk entries stasm/fluent.js
1 participant
@stasm