Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript definitions #329

Closed
huy-nguyen opened this issue Jan 9, 2019 · 4 comments
Closed

TypeScript definitions #329

huy-nguyen opened this issue Jan 9, 2019 · 4 comments

Comments

@huy-nguyen
Copy link

huy-nguyen commented Jan 9, 2019

I'm using fluent and quite like it. However, the project currently has no TypeScript definitions and I can create them if the maintainers so desire.

@Gregoor
Copy link
Contributor

Gregoor commented Jan 15, 2019

That's great! I've been meaning to add some for a while. We have some basic typings for fluent-react over at the Common Voice repo: https://github.com/mozilla/voice-web/blob/master/web/src/fluent-react.d.ts
Maybe this helps as a starting point.

@huy-nguyen
Copy link
Author

I've opened a PR for fluent, fluent-react and fluent-langneg at DefinitelyTyped/DefinitelyTyped#32235 if you wan to take a look. The files ending in -tests are examples of user-facing API to be tested against the type definitions. I didn't make the definitions for other packages because they don't seem to be user-facing.

@stasm stasm mentioned this issue May 28, 2019
7 tasks
@JamesNimlos
Copy link

I think this issue can be closed now seeing as the referenced definitions have been merged, as well as typedefs for the new versions were merged in DefinitelyTyped/DefinitelyTyped#40179

@stasm
Copy link
Contributor

stasm commented Jan 13, 2020

Yes, thanks!

I've also made good progress in #376 in which I migrated @fluent/bundle to TypeScript. When the PR lands, type definitions will become easy to manage (and will move to this repo). If all goes well, other @fluent/ packages will follow later this year.

@stasm stasm closed this as completed Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants