-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require indent before placeables #170
Comments
I see leading placeables to be in the same bucket as plain white-space lines and blank lines (just They're all leading to absent and/or invisible whitespace, and I expect the fix to be the same for each. I don't think we need special pre-cautions for placeables. |
OK, I agree, thanks @Pike. Let's close this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A follow-up to #87 based on the discussion in #162.
In #87 (PR #159) we relaxed the indentation requirement for all non-text. This included the placeable's opening brace. For instance:
fluent/test/fixtures/select_indent.ftl
Lines 15 to 18 in a1ed83f
fluent/test/fixtures/variants_indent.ftl
Lines 5 to 8 in a1ed83f
The discussion in #162 highlighted a possible issue for preserving some text indent caused by no indentation before placables (#162 (comment)). The issue might turn out to be solvable by the design of #162.
Just to be safe, however, should we require indent before placeables in 0.7?
The text was updated successfully, but these errors were encountered: