Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require indent before placeables #170

Closed
stasm opened this issue Aug 22, 2018 · 2 comments
Closed

Require indent before placeables #170

stasm opened this issue Aug 22, 2018 · 2 comments

Comments

@stasm
Copy link
Contributor

stasm commented Aug 22, 2018

A follow-up to #87 based on the discussion in #162.

In #87 (PR #159) we relaxed the indentation requirement for all non-text. This included the placeable's opening brace. For instance:

select-allman-inline =
{ $selector ->
*[key] Value
}

-variants-allman =
{
*[key] Value
}

The discussion in #162 highlighted a possible issue for preserving some text indent caused by no indentation before placables (#162 (comment)). The issue might turn out to be solvable by the design of #162.

Just to be safe, however, should we require indent before placeables in 0.7?

@Pike
Copy link
Contributor

Pike commented Aug 22, 2018

I see leading placeables to be in the same bucket as plain white-space lines and blank lines (just \n).

They're all leading to absent and/or invisible whitespace, and I expect the fix to be the same for each.

I don't think we need special pre-cautions for placeables.

@stasm
Copy link
Contributor Author

stasm commented Aug 30, 2018

OK, I agree, thanks @Pike. Let's close this then.

@stasm stasm closed this as completed Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants