-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADAL v3 #50
Comments
Is there any scenario we are missing and require ADAL v3? |
The scenario is using |
Are there any plans to support ADAL v3?
The
Microsoft.Azure.Management.*.Fluent
packages depend onMicrosoft.Rest.ClientRuntime.Azure.Authentication
, which depends onMicrosoft.IdentityModel.Clients.ActiveDirectory
version 2.x under .Net Framework 4.5.2 but version 3.x under .Net Framework 4.6.1.Since .Net Framework 4.5.2 is the very oldest framework not yet to be out of support, it seems a bit risky to target it. But the API change between
Microsoft.IdentityModel.Clients.ActiveDirectory
2.x and 3.x breaksARMClient
quite badly: all of the methods it uses fromAuthenticationContext
are either renamed or removed.Half of the problems are easily handled by shimming the missing
AcquireToken
methods with extension methods which callAcquireTokenAsync
, but the other half are due to ADAL v3 not exposing refresh tokens. AIUIAcquireTokenSilentAsync
is supposed to replaceAcquireTokenByRefreshTokenAsync
, but I don't understand ADAL well enough to be confident in writing a patch for this.The text was updated successfully, but these errors were encountered: