toBuilder throws an NPE when a @SIngular collection field is null

[jgraglia]

Hi, I'm facing the following pb :

Given this POJO :

@DaTa
@builder(toBuilder = true)
public class BuilderDemo {

private final Set<String> names;

@Singular
private final Set<String> singularNames;

}

a NPE is thrown when using toBuilder method on an instance created with a null singularNames field.

    final BuilderDemo nullNames = new BuilderDemo(Collections.EMPTY_SET, null);

    nullNames.toBuilder()  <= NPE ! 

    final BuilderDemo fromBuilder =  BuilderDemo.builder().build();

    fromBuilder.toBuilder()  <= NO NPE 

I can reproduce the problem always, and here is the link to a simple maven project demonstrating the problem :
https://github.com/jgraglia/lombokbuilderbug

I'm using lombok 1.16.14 on a JDK 8 project.

PS: I can not simply replace new BuilderDemo (...) with Builderdemo.builder() calls as this happens when deserializing a BuilderDemo from a json stream (using Jackson ObjectMapper)

Thx!

[jgraglia]

still no luck with lombok 1.16.16

[sarthakn7]

+1, facing the same issue.

[jesantana]

+1

[DmitryWh]

still no luck with lombok 1.16.18

[rzwitserloot]

You can test it out in the current edge release: https://projectlombok.org/download-edge