@Builder should respect @Nullable annotation

[lanusau]

Just like @Setter, @builder should copy @nullable annotation to the method that sets the value for the field.

For example, having this class:

@Builder
public class LombokNullable {
    @Nullable  private String stringValue;
}

Lombok generates:

public class LombokNullable {
    @Nullable  private String stringValue;

    @java.beans.ConstructorProperties({"stringValue"})
    LombokNullable(String stringValue) {
        this.stringValue = stringValue;
    }

    public static LombokNullableBuilder builder() {
        return new LombokNullableBuilder();
    }

    public static class LombokNullableBuilder {
        private String stringValue;

        LombokNullableBuilder() {
        }

        public LombokNullableBuilder stringValue(String stringValue) {
            this.stringValue = stringValue;
            return this;
        }

        public LombokNullable build() {
            return new LombokNullable(stringValue);
        }

        public String toString() {
            return "LombokNullable.LombokNullableBuilder(stringValue=" + this.stringValue + ")";
        }
    }

The method "public LombokNullableBuilder stringValue(String stringValue) {" should copy @nullable annotation to the parameter:
public LombokNullableBuilder stringValue(@Nullable String stringValue) {

Without this, IntelliJ's null inspection will flag this as a warning:
LombokNullable.builder().stringValue(methodAnnotatedWithNullable()

[voidengineer]

The same should be done for @nonnull annotations.
Further .builder() and .build() should be @nonnull too.

[rzwitserloot]

Fixed in latest edge, thanks to @wmdietl :)

https://projectlombok.org/download-edge

[Olard]

There still is the problem that the annotations are not copied to the fields in the builder. This triggers the eclipse null analysis :-(

[nithatech]

error: [NullAway] assigning @nullable expression to @nonnull field
@builder

[ondrej-simon]

This unfortunately still is not fixed and basically makes builder unusable along Kotlin, which introduces strict nullability detection.