Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Delegate should also generate @Deprecated when the interface methods javadoc contains@deprecated #421

Closed
lombokissues opened this issue Jul 14, 2015 · 7 comments
Assignees

Comments

@lombokissues
Copy link

Migrated from Google Code (issue 348)

@lombokissues
Copy link
Author

👤 buzz.taiki   🕗 Feb 23, 2012 at 17:32 UTC

What steps will reproduce the problem?

  1. Compile following code using javac with -Xlint:deprecation option.

import lombok.Delegate;
import java.sql.ResultSet;

public class LombokDelegateOnDeprecateSample {
private static class MyResultSet {
@ Delegate private final ResultSet rs;
public MyResultSet(ResultSet rs) {
this.rs = rs;
}
}
}

  1. javac shows following warnings.

$ javac -Xlint:deprecation -cp lombok.jar LombokDelegateOnDeprecateSample.java

warning: [deprecation] getBigDecimal(int,int) in java.sql.ResultSet has been deprecated
warning: [deprecation] getUnicodeStream(int) in java.sql.ResultSet has been deprecated
warning: [deprecation] getBigDecimal(java.lang.String,int) in java.sql.ResultSet has been deprecated
warning: [deprecation] getUnicodeStream(java.lang.String) in java.sql.ResultSet has been deprecated
4 warnings

What is the expected output? What do you see instead?

javac should not shows deprecation warnings.

What version of the product are you using? On what operating system?

0.10.8

Please provide any additional information below.

@lombokissues
Copy link
Author

👤 buzz.taiki   🕗 Feb 23, 2012 at 17:54 UTC

I wrote patch and send pull request for this issue into #29

Please apply it if there is no problem.

@lombokissues
Copy link
Author

👤 r.spilker   🕗 Feb 23, 2012 at 22:49 UTC

I've looked at the patch, and added feedback on github.

@lombokissues lombokissues added the accepted The issue/enhancement is valid, sensible, and explained in sufficient detail label Jul 14, 2015
@lombokissues
Copy link
Author

👤 r.spilker   🕗 Feb 23, 2012 at 23:23 UTC

Thanks for reporting the bug, and submitting a patch including a test.

@lombokissues
Copy link
Author

👤 r.spilker   🕗 Mar 05, 2012 at 20:02 UTC

Fixed in 82d9398.

@lombokissues lombokissues removed the accepted The issue/enhancement is valid, sensible, and explained in sufficient detail label Jul 14, 2015
@lombokissues
Copy link
Author

👤 buzz.taiki   🕗 Mar 06, 2012 at 02:49 UTC

Thanks!

@lombokissues
Copy link
Author

End of migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants