1.14.0 slowing down Eclipse (SpringTool Suite Edition) #717
Comments
|
👤 shawn.tuatara 🕗 May 28, 2014 at 16:31 UTC I went and updated my lombok to 1.14.0 yesterday afternoon. I noticed fairly quickly that my Eclipse slowed down considerably when making changes to files. Researching it a bit further this morning I found that in the eclipse log there is a lot of error messages for lombok starting at when I upgraded. Attached is the related log file. |
|
👤 shawn.tuatara 🕗 May 28, 2014 at 16:31 UTC |
|
👤 reinierz 🕗 May 30, 2014 at 00:30 UTC Dang. Can't reproduce, but that's definitely from the new code in 1.14 that attempts to find the lombok.config related to your source directory. Which eclipse version are you using, exactly? Is there anything particularly special about that project's set up? For example, is it a so-called 'linked' resource (example: is the directory of the project someplace else, other than as a direct subdirectory to your workspace dir?) Eclipse has a really REALLY weirdo idea of how to make strings that refer to resources in the workspace, and clearly we missed something. |
|
👤 shawn.tuatara 🕗 May 30, 2014 at 00:35 UTC It is a Spring Tool Suite version of Eclipse version 3.5.1 ( |
|
👤 reinierz 🕗 May 30, 2014 at 01:03 UTC Okay, I have an edge release version that won't produce quite so many errors, but it 'works' by basically not supporting lombok.config at all in your particular setup, which is of course not good. For now this edge release will log whenever this failure occurs, because we really do need to figure out when this happens and how to get an absolute path. Give it a shot and report back? Thanks a bunch for letting us know! https://projectlombok.org/download-edge.html If this doesn't lead anywhere useful I'm going to try and reproduce your situation, but there are tons of variables here, so that would take a long time. |
lombokissues
added
the
accepted
|
👤 shawn.tuatara 🕗 May 30, 2014 at 16:29 UTC So far this morning no errors are showing up. I did notice some lag on initial loading of a source file. As well I am noticing some odd syntax highlighting on the lombok annotations. Attached shows the @ Slf4j annotation in an italicized black font instead of the normal slightly brown font. As well when I added a @ Getter annotation on the sender it was with a blue font instead of the normal font. If I go back to 1.12.x the fonts show up normally. |
|
👤 shawn.tuatara 🕗 May 30, 2014 at 16:29 UTC |
|
👤 shawn.tuatara 🕗 May 30, 2014 at 16:29 UTC |
|
👤 shawn.tuatara 🕗 May 30, 2014 at 21:25 UTC So after using my Eclipse for the day I have not seen any errors show up in the log. Other than the weird colouring of the lombok annotations it seems to be stable. If you want me to try another edge build that would output more information and actually error again I don't have a problem trying it. |
|
👤 Maaartinus 🕗 May 31, 2014 at 04:50 UTC With my old Eclipse 3.7.2, I was having quite some problems and tons of "Path must include project and resource name" messages, too. Now (using the current master), they're gone. The colors aren't really weird, it's just that some areas (sometimes nearly everything) get all gray. Clicking around usually relocates the area or makes it disappear. |
|
👤 r.spilker 🕗 Jun 03, 2014 at 22:30 UTC This is NOT fixed at all, we merely hid the problem. The issue is that we try to find, as a sibling file to your source file, the file 'lombok.config', and there are some fancy scenarios where this doesn't work. So far we know of at least these 3:
The quick and dirty non-fix for all of these scenarios is to just not look for lombok.config at all but this is NOT A SOLUTION: The lombok config system is here to stay and we can't just randomly decide it's too hard to find it and stop there. However, that is exactly what the edge release currently does - hence, not a fix. We're currently looking into how to detect these scenarios, and, optimally, figure out how to still find lombok.config. This is an extremely difficult task because for a lot of the above scenarios, we do not have a system to reproduce, and it takes a lot of effort to create it (example: Installing rational whatsit with jazz and all that, well, that's a lot of work, obviously). So, it'll be slow going and require a lot of feedback. We're calling it a night for now. Progress on our research is on public branch: https://github.com/rzwitserloot/lombok/tree/configResolutionInEclipse In the mean time we have the rather acute problem that 1.14.0 is causing tons of show-stopping problems, so most likely we'll push a release out the door soon that'll catch these issues and instead post a warning in the eclipse log imploring the user to get back to us. |
|
👤 r.spilker 🕗 Jun 11, 2014 at 10:00 UTC About the sourcecontrol://jazz urls: thate are some pointers in: |
|
👤 r.spilker 🕗 Jun 24, 2014 at 18:46 UTC Issue #733 has been merged into this issue. |
|
👤 shawn.tuatara 🕗 Jun 25, 2014 at 21:19 UTC More feedback on this. I am now running 1.14.2 in my environment and while it isn't slowing down Eclipse the same way it was in the past it is still showing times when it is slow. The good thing is that when it is slow I can look at the Error Log and see that it is actually lombok trying to do something. I have been able to reproduce the problem for one situation:
At this moment you should see a dialog saying that it is loading the compare but it takes it a brief second or two before the comparison dialog shows up. If you then look at the Error Log you will see entries like the one below. eclipse.buildId=3.5.1.201405030657-RELEASE-e43 This is a continuation of log file C:\Development\Workspaces\sts-3.5.x.metadata.bak_0.log Warning java.lang.IllegalArgumentException: Path must include project and resource name: / |
|
👤 r.spilker 🕗 Jun 26, 2014 at 09:07 UTC We've created a new edge release: https://projectlombok.org/download-edge.html |
|
👤 r.spilker 🕗 Jun 26, 2014 at 09:08 UTC Any feedback is appreciated... |
|
👤 shawn.tuatara 🕗 Jun 26, 2014 at 20:56 UTC A little better with the latest edge build. Before the error would show up about 10-15 times in the log at the same time. Now it only shows up about 6-8 times. Similar error: eclipse.buildId=3.5.1.201405030657-RELEASE-e43 Warning java.lang.IllegalArgumentException: Path must include project and resource name: / |
|
👤 joerg.stoever 🕗 Jul 05, 2014 at 15:04 UTC For what it's worth, this definitely seems to be source control/git related, today I worked with two projects for a few hours and had no issues, and then worked on a third and had massive slowdown problems and the above mentioned log messages. All in the same Eclipse and the same workspace, all having the same lombok dependency in their pom.xml. The only difference between them was the third project being a git project. |
|
👤 matthew.painter@import.io 🕗 Jul 06, 2014 at 13:27 UTC I can confirm this is still a problem with Luna RC3 and git projects. It also seems to slow down code completion horrifically compared to 12.6 |
|
👤 gsolecki8 🕗 Jul 15, 2014 at 07:47 UTC I have exactly the same effect. This applies to version 1.14.0, 1.14.2 and 1.14.4. I use a clean version of Eclipse Luna JavaEE Full Release. The environment is so slow that you can not work and the only solution is to go back to version 1.12.6. |
|
👤 shawn.tuatara 🕗 Jul 15, 2014 at 08:15 UTC To help the developers... Whenever it is slow go check out the Error Log and see if there is any Lombok errors. If so copy them here and help track down the roots of this problem. |
|
👤 matthew.painter@import.io 🕗 Jul 15, 2014 at 16:30 UTC No errors, but lots of lombok.config not found kind of messages... |
|
👤 shawn.tuatara 🕗 Jul 15, 2014 at 16:45 UTC Those messages are what the issue is so copy one of them here so they can take a look. |
|
👤 charlee.ch 🕗 Jul 17, 2014 at 08:08 UTC I'm using the following: - eclipse.buildId=4.3.2.M20140221-1700 The lombok version is Manifest-Version: 1.0 The stacktrace is !ENTRY org.eclipse.jdt.core 2 0 2014-07-17 14:46:33.470 |
|
👤 shawn.tuatara 🕗 Jul 18, 2014 at 21:25 UTC I am now using Spring Tool Suite 1.6 (Eclipse 4.4). I am noticing the below error in the log. This happens whenever I save a class file. null java.lang.IllegalArgumentException: Path must include project and resource name: / |
|
👤 jeacott1 🕗 Aug 07, 2014 at 01:22 UTC I too am experiencing this unworkable slowdown with eclipse content assist. I had no other errors except the !MESSAGE Finding 'lombok.config' file failed for 'myfile.java' so I generated a lombok.config, and placed it into the workspace root and restarted eclipse. I have just 2 projects in my workspace, they are both pretty small, but they are also both git projects, and eclipse moves these outside the usual workspace directory. I also just for kicks, created a new workspace, generated a new maven web project, and added lombok 1.14.4. I hope this issue gets fixed soon. lombok 1.12.6 doesn't work in my luna eclipse at all. |
|
👤 rinaldo90 🕗 Aug 11, 2014 at 01:52 UTC Same here: !ENTRY org.eclipse.jdt.core 2 0 2014-08-10 22:30:14.077 |
|
👤 reinierz 🕗 Aug 15, 2014 at 23:52 UTC We can reproduce the gigantic pile of errors, but we can't reproduce the slowdown effect. We removed the thing that generates all the errors (generating stack traces, as well as all the code that runs before the error occurs, is all skipped now, very quickly, if the error would occur); we think that should help a lot with the slowdown but we can't test that because we can't reproduce the slowdown aspect. Please give this edge release a try and report back? Many thanks! |
|
👤 jeacott1 🕗 Aug 18, 2014 at 00:07 UTC edge version made no difference for me. eclipse.buildId=4.4.0.I20140606-1215 !ENTRY org.eclipse.egit.ui 2 0 2014-08-18 09:01:15.487 |
|
👤 fabrice.daugan 🕗 Aug 19, 2014 at 13:23 UTC I have the same issue on Eclipse 4.4, lombok 1.14.4, on JSE8 : !MESSAGE Finding 'lombok.config' file failed for 'JiraExportPluginResource.java' |
|
👤 r.spilker 🕗 Aug 20, 2014 at 23:10 UTC We have another edge release. This one lets you both do some fine grained debugging to see if config loading is the problem, as well as disable the whole config system to check if things are then back to normal speed. Make sure to read the changelog to see how to turn these options on; by default this edge release is no different from the last! |
|
👤 r.spilker 🕗 Aug 22, 2014 at 11:03 UTC Issue #763 has been merged into this issue. |
|
👤 gilgamesh21ster 🕗 Aug 27, 2014 at 16:54 UTC The edge release plus the -Dlombok.disableConfig brings my eclipse luna back to normal performance! |
|
👤 Justin.Harris@maluuba.com 🕗 Aug 27, 2014 at 17:39 UTC +1 "The edge release plus the -Dlombok.disableConfig brings my eclipse luna back to normal performance!" What will the fix be? |
|
👤 Justin.Harris@maluuba.com 🕗 Aug 27, 2014 at 19:59 UTC Using the edge release with -Dlombok.disableConfig give me an issue with @ RequiredArgsConstructor: Lombok annotation handler class lombok.eclipse.handlers.HandleConstructor$HandleRequiredArgsConstructor failed java.lang.NullPointerException |
|
👤 gilgamesh21ster 🕗 Sep 01, 2014 at 16:49 UTC Yeah, After a clean and Build ALL, I get the same issues as in ﹟32 too. |
|
👤 gilgamesh21ster 🕗 Sep 01, 2014 at 17:00 UTC If I have a look at Line 1049 of lombok.eclipse.handlers.EclipseHandlerUtil.removePrefixFromField, a field.getAst().readConfiguration(ConfigurationKeys.ACCESSORS_PREFIX); is done. But since we've set -Dlombok.disableConfig there is no configuration field.getAst().readConfiguration can work upon and that will lead to the variable prefixes be set to null. This would cause in Line 1050 the NullPointerException (!prefixes.isEmpty()) |
|
👤 gilgamesh21ster 🕗 Sep 02, 2014 at 07:54 UTC I made a fork and tried the fix. I don't get the error above in my Eclipse any longer. In the attachment is a build with my fix. Maybe give it a try. |
|
👤 gilgamesh21ster 🕗 Sep 02, 2014 at 07:54 UTC |
|
👤 reinierz 🕗 Sep 02, 2014 at 21:46 UTC Release v1.14.6 is now out and official. We fixed the issue with -Dlombok.disableConfig causing NPEs, and more importantly, we probably fixed the slowdown issue entirely, but, we're not 100% sure on that (as we can't reproduce it). To those suffering from the issue, give v1.14.6 a shot, and post -Dlombok.timeConfig results if you can. Thanks! |
|
👤 gilgamesh21ster 🕗 Sep 04, 2014 at 14:58 UTC Unfortunately things are not better. I have put back the -Dlombok.disableConfig and the code completion works again. Here the results from the -Dlombok.timeConfig: !ENTRY org.eclipse.jdt.core 1 0 2014-09-04 16:48:00.003 !ENTRY org.eclipse.jdt.core 1 0 2014-09-04 16:48:00.009 !ENTRY org.eclipse.jdt.core 1 0 2014-09-04 16:48:00.012 !ENTRY org.eclipse.jdt.ui 2 0 2014-09-04 16:48:23.686 !ENTRY org.eclipse.jdt.core 1 0 2014-09-04 16:49:00.005 !ENTRY org.eclipse.jdt.ui 2 0 2014-09-04 16:49:00.459 !ENTRY org.eclipse.jdt.ui 2 0 2014-09-04 16:49:21.664 |
|
👤 shams.asari 🕗 Sep 07, 2014 at 08:20 UTC Also still slow for me. Here's the output of my log file: !ENTRY org.eclipse.jdt.core 1 0 2014-09-07 09:17:00.012 !ENTRY org.eclipse.jdt.core 1 0 2014-09-07 09:18:07.810 !ENTRY org.eclipse.jdt.core 1 0 2014-09-07 09:18:21.901 !ENTRY org.eclipse.jdt.ui 2 0 2014-09-07 09:18:36.391 !ENTRY org.eclipse.m2e.logback.appender 2 0 2014-09-07 09:18:44.132 !ENTRY org.eclipse.m2e.logback.appender 2 0 2014-09-07 09:18:44.161 !ENTRY org.eclipse.jdt.core 1 0 2014-09-07 09:19:02.310 |
|
👤 gvmson 🕗 Sep 10, 2014 at 03:21 UTC Still happening to me - Mac OS, Eclipse Luna |
|
👤 gvmson 🕗 Sep 10, 2014 at 03:21 UTC |
|
👤 gdvtcl2000 🕗 Sep 16, 2014 at 02:04 UTC Eclipse works fine when MyController.java uses (imports) 5 DTO classes, each with @ Data @ NoArgsConstructor @ AllArgsConstructor. |
|
👤 bengunnink 🕗 Sep 16, 2014 at 02:36 UTC 1.14.8 is a huge improvement over the previous 1.14.x series, but still almost half again as slow as 1.12.6. This is w/o Eclipse: a large-ish (1152 source files) Maven-based project. My times for running "mvn compile" on a clean project are: Lombok Time (s)1.12.6 21 The bugfix present in 1.14.8 clearly has a pretty significant effect on I/O, but the Lombok config system even w/o the bug adds a lot of overhead to the compilation process. |
|
👤 lirany2 🕗 Sep 16, 2014 at 14:25 UTC Just tested 1.14.8, it's still a lot slower than 1.12.6 . |
|
👤 shawn.tuatara 🕗 Sep 18, 2014 at 19:44 UTC 1.14.8 is working a lot better than any other build since the 1.12.x builds. Here is the latest logs: !ENTRY org.eclipse.jdt.core 1 0 2014-09-17 15:59:18.487 !ENTRY org.eclipse.jdt.core 1 0 2014-09-17 16:00:05.412 !ENTRY org.eclipse.jdt.core 1 0 2014-09-17 16:00:23.935 !ENTRY org.eclipse.jdt.core 1 0 2014-09-17 16:01:05.224 !ENTRY org.eclipse.jdt.core 1 0 2014-09-17 16:02:19.070 !ENTRY org.eclipse.jdt.core 1 0 2014-09-17 16:03:04.125 !ENTRY org.eclipse.jdt.core 1 0 2014-09-17 16:04:01.258 !ENTRY org.eclipse.jdt.core 1 0 2014-09-17 16:05:38.163 !ENTRY org.eclipse.jdt.core 1 0 2014-09-17 16:06:01.508 |
|
End of migration |
Migrated from Google Code (issue 682)
The text was updated successfully, but these errors were encountered: