Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in README tutorial #20

Closed
majdal opened this issue Feb 27, 2020 · 4 comments
Closed

Consistency in README tutorial #20

majdal opened this issue Feb 27, 2020 · 4 comments

Comments

@majdal
Copy link
Contributor

majdal commented Feb 27, 2020

Going through the tutorial in README, there's a small error that that took me a bit of investigating to figure out, so maybe it's worthwhile to correct. I'm happy to create a pull request, but first I'd like to hear from the author/community about what's the best way to correct it.

The GeoJSON that you provide in the example is in WGS84 (EPSG:4326), not in WGS 84 / Pseudo-Mercator (EPSG:3857). With the default CRS (3857), the example shows a blank box instead of the map of Arizona. Setting the CRS explicitly in the AgentCreator to 4326 fixes the issue. The image attached should be corrected to look like the following:

Arizona map at epsg:4326

The image currently in the tutorial is the one below, and it's in epsg:2163. The difference might create some unnecessary confusion to a beginner.

Arizona map at epsg:2163

This also means that the distance calculation (m.grid.get_neighbors_within_distance(agent, 600000)) has the wrong distance/units.

Should we move the reference to explicitly setting the CRS to be just after the model definition?

@ArcPam
Copy link

ArcPam commented May 8, 2020

This might be why my files are defaulting to the top of the page. Do you know how to fix that issue?

@majdal
Copy link
Contributor Author

majdal commented May 10, 2020

@ArcPam I'm not sure I understand your question... More details please

@ArcPam
Copy link

ArcPam commented May 10, 2020

I was able to fix the issue by projecting all data in 4326 and it fixed the issue.

@wang-boyu
Copy link
Member

Introductory tutorial has changed to a step-by-step SIR model using Solara visualization in Jupyter notebook. Hence this issue no longer exists. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants