Replies: 1 comment
-
Just for reference, I do not advocate for having strictly one class per file. I didn't even do it in the PR. My comment was just meant in response to the question of how to split the file. Ending up with (mostly) one class per file was just incidently. I am used to this from my component-based frontend development (although I am not using classes there). But mesa isn't a frontend project. What I am advocating for is organizing files by feature. So each distinctive and independent feature should reside in its own file. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In #1994 (comment) I objected to @Corvince's choice of having 1 file per class. This is not the standard convention in Python. To reply on #1994 (comment),
Citation needed. On the contrary, Java had, since the early days, organized based on 1 file/class. So I don't see how it was a limitation in the early days until Python developers decided to use Java convention.
What I find makes sense is point 2 and 3 of #1994 (comment). In a way, it's a 2 layer organization: files, and then classes. The 400 LOC shouldn't be a hard requirement. But, beyond 1k LOC would make sense for the split.
For reading:
Beta Was this translation helpful? Give feedback.
All reactions