Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JupyterViz: the default grid space drawer doesn't scale to large size #1741

Closed
rht opened this issue Jul 25, 2023 · 5 comments · Fixed by #2049
Closed

JupyterViz: the default grid space drawer doesn't scale to large size #1741

rht opened this issue Jul 25, 2023 · 5 comments · Fixed by #2049

Comments

@rht
Copy link
Contributor

rht commented Jul 25, 2023

Describe the bug

Here is Schelling space for 60x60:
2023-07-24-102909_468x350_scrot

Expected behavior

Should either scale down the circle marker size automatically, or scale up the figure size automatically.

@rlskoeser
Copy link
Contributor

I vote for scaling up the figure size (which I'm understanding as allocating more space for the agent space figure on the page). Not sure how you would determine the threshold for this - would it have to be user configurable, or could a certain grid size automatically require 3/4 of the width, full width?

@rht
Copy link
Contributor Author

rht commented Sep 15, 2023

I think we should do both simultaneously.

@ankitk50
Copy link
Contributor

I started looking into this-- some upfront ideas here:

  1. If we need to make the figure scalable , I would be better if we make the plots one per row (so that the scaling can be done to the whole screen).

  2. I think it would be better to implement it as a test feature that can be enabled via a checkbox.

  3. The agents size looks straight forward to scale based on number of agents. I look into ways to scale the figure. GridDraggable in solara looks like a promising feature in this regard.

@rht
Copy link
Contributor Author

rht commented Sep 25, 2023

There shouldn't be upfront customization from the user unless necessary. This should behave like how LaTeX renders documents, where people focus on the content of the writing, not the layout. Automatically deciding when to use the entire row or not, scaling down marker size, increasing figure size, should be the library's responsibility.

@ankitk50
Copy link
Contributor

ankitk50 commented Sep 25, 2023

Sure, I have opened a draft PR #1820.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants