Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up private variables (_agents, _step) #2212

Closed
EwoutH opened this issue Aug 15, 2024 · 4 comments
Closed

Clean-up private variables (_agents, _step) #2212

EwoutH opened this issue Aug 15, 2024 · 4 comments
Labels
breaking Release notes label
Milestone
v3.0

Comments

@EwoutH
Copy link
Member

EwoutH commented Aug 15, 2024 •
edited
Loading

To keep backwards compatibility with Mesa 2.x, we added some attributes as private ones, like _agents and _step. We should clean that up for 3.0.

See:
@EwoutH EwoutH added the breaking Release notes label label Aug 15, 2024
@EwoutH EwoutH mentioned this issue Aug 19, 2024
Merged
@EwoutH
Copy link
Member Author

EwoutH commented Aug 30, 2024

Partly done in #2251 (agents_ removal) and #2223 (_time removal and _steps renamed to steps).

@EwoutH EwoutH added this to the v3.0 milestone Sep 3, 2024
@quaquel
Copy link
Member

quaquel commented Sep 23, 2024

What's still remaining?

@EwoutH
Copy link
Member Author

EwoutH commented Sep 23, 2024

It’s mentioned in the migration guide, but I think we want to enforce this somehow.

@EwoutH
Copy link
Member Author

EwoutH commented Sep 23, 2024

That would actually be

So closing this one.

@EwoutH EwoutH closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Release notes label
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
2 participants
@quaquel @EwoutH