Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Value changes not reconciled/redeployed #499

Closed
Uva-Vj opened this issue Apr 5, 2024 · 4 comments
Closed

BUG: Value changes not reconciled/redeployed #499

Uva-Vj opened this issue Apr 5, 2024 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Uva-Vj
Copy link

Uva-Vj commented Apr 5, 2024

Problem Description

Any changes to values of helm charts defined in ClusterProfile doesn’t reconcile/redeploy K8s controllers. Is this expected behavior?

For example, When I apply the below values to the already defined nginx helm chart with no values in ClusterProfile, the nginx deployment doesn’t get redeployed. The addon-controller log shows added to result with err cannot re-use a name that is still in use. Does this mean the releaseName should be updated with every value change? If I change the releaseName
/chartVersion reconcile happens and new nginx pods get deployed without any issue.

Seems similar to #93 but for non-templated values.

New Values:

    values: |-
      containerPorts:
        http: 8190

ClusterProfile.yml

apiVersion: config.projectsveltos.io/v1alpha1
kind: ClusterProfile
metadata:
  name: nginx
spec:
  clusterSelector: cluster=vcenter1-lab
  syncMode: Continuous
  helmCharts:
  - repositoryURL:    artifactory/kubernetes-helm
    repositoryName:   kubernetes-helm
    chartName:        kubernetes-helm/nginx
    chartVersion:     13.1.7
    releaseName:      nginx-sveltos
    releaseNamespace: k8s-admin
    helmChartAction:  Install

System Information

CLUSTERAPI VERSION: v1.6.1
SVELTOS VERSION: v0.26.0
KUBERNETES VERSION: v1.29.0

Logs

│ I0405 07:35:07.142197       1 worker.go:238] "added to result with err cannot re-use a name that is still in use" logger="deployer" worker="6" key="default:::vcenter1-lab:::Capi:::nginx-capi-vcenter1-lab:::Helm:::false"
@Uva-Vj Uva-Vj added the bug Something isn't working label Apr 5, 2024
@gianlucam76 gianlucam76 self-assigned this Apr 5, 2024
@gianlucam76
Copy link
Member

Thank you @Uva-Vj for filing this issue. I will look into and update.

@gianlucam76
Copy link
Member

The main issue I see is that once an helm chart is installed, changing values section has no effect. Sveltos checks current installed version and the version to be installed. Given those are same it thinks that is a no-op.

I will fix this behaviour in next release (v0.28.0)

@gianlucam76
Copy link
Member

gianlucam76 commented Apr 17, 2024

Fix for this will be in v0.28.0 which should be released by end of this week.

@gianlucam76
Copy link
Member

Release v0.28.0 is out and contains fix for this https://github.com/orgs/projectsveltos/discussions/510

@Uva-Vj I am closing this. But please let me know if you still see issues.

Thank you again for the detailed description. Really appreciated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants