Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve comments #106

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Preserve comments #106

wants to merge 10 commits into from

Conversation

bartveneman
Copy link
Member

closes #26

Copy link

codecov bot commented Oct 13, 2024

Bundle Report

Changes will increase total bundle size by 2.44kB (28.22%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
formatCss-formatCss-esm 6.54kB 1.6kB (32.34%) ⬆️⚠️
formatCss-formatCss-esm-formatCss-umd 4.53kB 839 bytes (22.71%) ⬆️⚠️

Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #106 will not alter performance

Comparing preserve-comments-v20 (56db99b) with main (50f42e4)

Summary

✅ 4 untouched benchmarks

@bartveneman
Copy link
Member Author

Another test case:

.button-secondary:hover,
.button-secondary:focus,
.button-secondary:active {
	--border-top-color: var(--root-color--secondary-dark);
	--border-right-color: var(--root-color--secondary-dark);
	--border-bottom-color: var(--root-color--secondary-dark);
	--border-left-color: var(--root-color--secondary-dark);
	--background-color: var(--root-color--secondary-dark);
}
/* Support style */
.button-support {
	--background-color: var(--root-color--support);

	/*--font-family: inherit;*/
	/*--font-size: var(--root-font-size); !* Reset, use REM *!*/
	/*--font-style: normal;*/
	/*--font-weight: var(--root-font-weight--semi-bold);*/
	/*--line-height: inherit;*/	/*--border-radius: var(--root-border-radius);*/
	--border-top-color: var(--root-color--support);

	/*--font-family: inherit;*/
	/*--font-size: var(--root-font-size); !* Reset, use REM *!*/
	/*--font-style: normal;*/
	/*--font-weight: var(--root-font-weight--semi-bold);*/
	/*--line-height: inherit;*/	--border-right-color: var(--root-color--support);

	/*--font-family: inherit;*/
	/*--font-size: var(--root-font-size); !* Reset, use REM *!*/
	/*--font-style: normal;*/
	/*--font-weight: var(--root-font-weight--semi-bold);*/
	/*--line-height: inherit;*/	--border-bottom-color: var(--root-color--support);

	/*--font-family: inherit;*/
	/*--font-size: var(--root-font-size); !* Reset, use REM *!*/
	/*--font-style: normal;*/
	/*--font-weight: var(--root-font-weight--semi-bold);*/
	/*--line-height: inherit;*/	--border-left-color: var(--root-color--support);

	/*--font-family: inherit;*/
	/*--font-size: var(--root-font-size); !* Reset, use REM *!*/
	/*--font-style: normal;*/
	/*--font-weight: var(--root-font-weight--semi-bold);*/
	/*--line-height: inherit;*/	--color: var(--root-color-text);
	/*--font-family: inherit;*/
	/*--font-size: var(--root-font-size); !* Reset, use REM *!*/
	/*--font-style: normal;*/
	/*--font-weight: var(--root-font-weight--semi-bold);*/
	/*--line-height: inherit;*/
}
  • declaration following a comment should always be on a new line
  • a comment before a rule should be preceded by an empty line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Do better at preserving comments
1 participant