Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint fails in nested projects #144

Merged
merged 1 commit into from
Oct 4, 2020
Merged

fix: eslint fails in nested projects #144

merged 1 commit into from
Oct 4, 2020

Conversation

hoegertn
Copy link
Contributor

@hoegertn hoegertn commented Oct 2, 2020

For nested projects eslint fails because it parses all parent configs too.
By setting the root flag, eslint stops looking in parent directories.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eladb eladb changed the title feat: improve nested projects; set eslint to root fix: eslint fails in nested projects Oct 4, 2020
@mergify mergify bot merged commit eabd2c7 into projen:master Oct 4, 2020
@hoegertn hoegertn deleted the nested-eslint branch October 4, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants