Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: synthesizing react subproject fails due to stack overflow #481

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

Chriscbr
Copy link
Contributor

Fixes #480


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #481 (959e2e5) into master (949e777) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   75.97%   75.99%   +0.01%     
==========================================
  Files          75       75              
  Lines        2681     2683       +2     
  Branches      696      697       +1     
==========================================
+ Hits         2037     2039       +2     
  Misses        641      641              
  Partials        3        3              
Impacted Files Coverage Δ
src/util.ts 85.54% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e17704...959e2e5. Read the comment docs.

@Chriscbr Chriscbr requested a review from eladb January 11, 2021 07:21
@mergify mergify bot merged commit 39b2dbe into projen:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReactTypeScriptProject throws errors if it is a subproject
3 participants