Issue with sessionduration since latest v3.1. Extension is not working

[shubhkb]

There is an issue in latest version 3.1, in script.js file inside onBeforeRequestEvent function sessionduration is not defined because of that it is not working please fix this asap.

let sessionduration = undefined;

[prolane]

Hi @shubhkb
The line you are referring to is just the declaration of the variable.

Could you post the debug logs here?
See https://github.com/prolane/samltoawsstskeys#faq-frequently-asked-question for help.

[mimol91]

@prolane

[Bobatron]

I have been having this same issue since last Friday:

Whilst this is being fixed, a workaround to getting the credentials file to downloaded is:

1. View the extension settings via the 'Manage Extension' option
2. Enable developer mode:
   
3. Inspect the service worker view:
   
4. From the console, set the value for sessionduration:
   
5. Connect to AWS and the credentials file should download as expected

[shubhkb]

Hi @shubhkb The line you are referring to is just the declaration of the variable.

Could you post the debug logs here? See https://github.com/prolane/samltoawsstskeys#faq-frequently-asked-question for help.

[prolane]

With the refactoring of the code due to Chrome Extension manifest V3 there was indeed a bug introduced related to the sessionduration. I was able to reproduce the issue. You'll encounter this issue when your IDP does not add a Session Duration as one of the SAML Assertion attributes.

This is now fixed with this:

samltoawsstskeys/background/script.js

Line 143 in 86a2c87

if (typeof sessionduration === 'undefined' || !ApplySessionDuration) {

I'll publish v3.2 tonight in the Chrome web store.

Please let me know if this indeed fixed it for you.

[shubhkb]

sessionduration

sessionduration This variable was not declared in onBeforeRequestEvent function to fix this you need to declare the variable.

[prolane]

@shubhkb I agree with you I should declare the variable in a next updated version and I will. For now I don't think it will make any functional difference, does it? The sessionduration variable will implicitly be a global variable due to:

samltoawsstskeys/background/script.js

Line 116 in 86a2c87

sessionduration = attributes[i].AttributeValue['#text']

If your IDP does not include the SessionDuration Attribute, the sessionduration will be typeof 'undefined' as now checked on that line 143 where the error occurred.

samltoawsstskeys/background/script.js

Line 143 in 86a2c87

if (typeof sessionduration === 'undefined' || !ApplySessionDuration) {

[prolane]

Closing this issue as this has been resolved and no new comments haven been left here.