Skip to content

Commit ff275a4

Browse files
committed
Fix mapping for database/relation names
Signed-off-by: Moritz Wirth <mw@flanga.io>
1 parent 3eebf9a commit ff275a4

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

collector/pg_table.go

+11-11
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ var (
4545
"total_relation",
4646
),
4747
"Total Relation Size of the table",
48-
[]string{"schemaname", "datname", "relname"}, nil,
48+
[]string{"schemaname", "relname", "datname"}, nil,
4949
)
5050
pgTableIndexSizeDesc = prometheus.NewDesc(
5151
prometheus.BuildFQName(
@@ -54,7 +54,7 @@ var (
5454
"index",
5555
),
5656
"Indexes Size of the Table",
57-
[]string{"schemaname", "datname", "relname"}, nil,
57+
[]string{"schemaname", "relname", "datname"}, nil,
5858
)
5959
pgRelationSizeDesc = prometheus.NewDesc(
6060
prometheus.BuildFQName(
@@ -63,11 +63,11 @@ var (
6363
"relation",
6464
),
6565
"Relation Size of the table",
66-
[]string{"schemaname", "datname", "relname"}, nil,
66+
[]string{"schemaname", "relname", "datname"}, nil,
6767
)
6868
pgTableSizeQuery = `SELECT
69-
table_catalog datname,
70-
table_name relname,
69+
table_catalog relname,
70+
table_name datname,
7171
table_schema schemaname,
7272
pg_total_relation_size('"'||table_schema||'"."'||table_name||'"') total_relation_size,
7373
pg_relation_size('"'||table_schema||'"."'||table_name||'"') relation_size,
@@ -86,14 +86,14 @@ func (c PGTableSizeCollector) Update(ctx context.Context, instance *instance, ch
8686
}
8787
defer rows.Close()
8888
for rows.Next() {
89-
var tableSchema, tableName, databaseName sql.NullString
89+
var schemaName, relName, databaseName sql.NullString
9090
var totalRelationSize, relationSize, indexesSize sql.NullInt64
9191

92-
if err := rows.Scan(&databaseName, &tableName, &tableSchema, &totalRelationSize, &relationSize, &indexesSize); err != nil {
92+
if err := rows.Scan(&databaseName, &relName, &schemaName, &totalRelationSize, &relationSize, &indexesSize); err != nil {
9393
return err
9494
}
9595

96-
if !tableSchema.Valid || !tableName.Valid || !databaseName.Valid {
96+
if !schemaName.Valid || !relName.Valid || !databaseName.Valid {
9797
continue
9898
}
9999

@@ -115,19 +115,19 @@ func (c PGTableSizeCollector) Update(ctx context.Context, instance *instance, ch
115115
ch <- prometheus.MustNewConstMetric(
116116
pgTableTotalRelationDesc,
117117
prometheus.CounterValue, totalRelationsSizeMetric,
118-
tableSchema.String, databaseName.String, tableName.String,
118+
schemaName.String, relName.String, databaseName.String,
119119
)
120120

121121
ch <- prometheus.MustNewConstMetric(
122122
pgRelationSizeDesc,
123123
prometheus.CounterValue, relationSizeMetric,
124-
tableSchema.String, databaseName.String, tableName.String,
124+
schemaName.String, relName.String, databaseName.String,
125125
)
126126

127127
ch <- prometheus.MustNewConstMetric(
128128
pgTableIndexSizeDesc,
129129
prometheus.CounterValue, indexesSizeMetric,
130-
tableSchema.String, databaseName.String, tableName.String,
130+
schemaName.String, relName.String, databaseName.String,
131131
)
132132
}
133133

0 commit comments

Comments
 (0)