Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Set - Private process counter is collected but not exposed as a metric #797

Closed
bsosnader opened this issue Jun 7, 2021 · 2 comments · Fixed by #809
Closed

Working Set - Private process counter is collected but not exposed as a metric #797

bsosnader opened this issue Jun 7, 2021 · 2 comments · Fixed by #809
Assignees

Comments

@bsosnader
Copy link

We were using windows_exporter to collect process metrics and noticed the Working Set - Private counter is not one of the metrics exposed. However, it is collected here:

WorkingSetPrivate float64 `perflib:"Working Set - Private"`

Is there any reason why this is not exposed? Could we contribute this by adding a metric following the pattern of the other process metrics?

@breed808
Copy link
Contributor

Hi @bsosnader, this metric appears to have been missed during the initial implementation, along with Working Set Peak.
You're more than welcome to submit a PR to fix this. Otherwise I can submit a fix.

@bsosnader
Copy link
Author

Hey @breed808 thanks for taking a look--would appreciate if you were able to submit a fix, I planned to but have been lacking the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants