Cleanup golangci-lint errcheck (#1339)

Move the errcheck excludes list from an external file to inline in the golangci-lint config file. Signed-off-by: SuperQ <superq@gmail.com>
prometheus · Sep 3, 2023 · d03abf3 · d03abf3
1 parent ca6ba04
commit d03abf3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -53,7 +53,11 @@ linters-settings:
         #- pkg: "regexp"
         #  desc: "Use github.com/grafana/regexp instead of regexp"
   errcheck:
-    exclude: scripts/errcheck_excludes.txt
+    exclude-functions:
+      # The following 2 methods always return nil as the error
+      - (*github.com/cespare/xxhash/v2.Digest).Write
+      - (*github.com/cespare/xxhash/v2.Digest).WriteString
+      - (*bufio.Writer).WriteRune
   goimports:
     local-prefixes: github.com/prometheus/client_golang
   gofumpt:

diff --git a/scripts/errcheck_excludes.txt b/scripts/errcheck_excludes.txt