Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GoCollector metrics in 1.12 do not pass promtool check metrics lint #1026

Closed
chancez opened this issue Apr 11, 2022 · 1 comment · Fixed by #1048
Closed

New GoCollector metrics in 1.12 do not pass promtool check metrics lint #1026

chancez opened this issue Apr 11, 2022 · 1 comment · Fixed by #1048
Labels

Comments

@chancez
Copy link

chancez commented Apr 11, 2022

Using git tag v1.12.1, if we run promtool check metrics on our metrics we get the following failure:

go_gc_heap_allocs_by_size_bytes_total non-counter metrics should not have "_total" suffix
go_gc_heap_frees_by_size_bytes_total non-counter metrics should not have "_total" suffix
go_gc_pauses_seconds_total non-counter metrics should not have "_total" suffix

It seems that new metrics were potentially introduced in #955

I also filed prometheus/prometheus#10574 before realizing these are new metrics as part of a library upgrade, though it still seems useful in general.

@bwplotka
Copy link
Member

Hmm, those are indeed histogram metrics, which are derived from runtime/metrics - thanks for pointing.

I would really consider renaming it now, given it's a fresh change (but this will break some compatibility though). Let me look on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants