Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Tests do not appear to verify request parameters #1034

Closed
josephwoodward opened this issue Apr 21, 2022 · 3 comments
Closed

API Tests do not appear to verify request parameters #1034

josephwoodward opened this issue Apr 21, 2022 · 3 comments
Assignees
@josephwoodward

Comments

@josephwoodward
Copy link
Contributor

josephwoodward commented Apr 21, 2022 •
edited
Loading

Whilst working on updating the Query API to support timeouts I noticed that the API tests do not currently verify the request parameters against the reqParam type configured as part of the test.

This can be verified by deleting all the request parameters within Query (for instance) and the tests will continue to pass.

image

I'm happy to raise a PR to address this.
@kakkoyun
Copy link
Member

Feel free to address it. Anything improves the quality assurance is much appreciated :)

@josephwoodward
Copy link
Contributor Author

@kakkoyun I've made a start on ensuring the tests cover the request parameters here.

@josephwoodward
Copy link
Contributor Author

This can be closed as it's been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephwoodward josephwoodward

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kakkoyun @josephwoodward