Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp in metrics not supported #315

Closed
br-privacore opened this issue Jun 23, 2017 · 1 comment
Closed

Timestamp in metrics not supported #315

br-privacore opened this issue Jun 23, 2017 · 1 comment

Comments

@br-privacore
Copy link

We scrape metrics from servers every minute using the https://github.com/tgulacsi/prometheus_scollector/ "proxy", in order to use scollector plugins.

The collected data contains number of events the last minute (reset every minute).

I worry about the timing of things here:

  1. scollector script runs every 55 seconds to collect data and send to prometheus_scollector proxy.
  2. prometheus_scollector proxy holds the data for a minute
  3. Prometheus scrapes every minute to collect that data.

scollector script could be a bit delayed because of high resource usage, and Prometheus could read the same sample twice.

It seems like the timestamp used in the scollector sample data is thrown away by the prometheus_scollector proxy and therefore not scraped by Prometheus. It would expect it to have been used for sample deduplication.

Is there a way to handle sample deduplication by passing on a "unique key" to Prometheus?

Brian Brazil on the prometheus-users mailing list:
The way to do that is via the timestamp. That's not supported by any client library yet though, including the Go client which prometheus_scollector uses.

@beorn7
Copy link
Member

beorn7 commented Jun 26, 2017

Yes, this is #187 .

Marking this as dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants