We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't help strings and label values be escaped?
https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#escaping
The text was updated successfully, but these errors were encountered:
Good point @blckngm. Thanks for reporting. Yes.
I wonder whether we should actively escape them or simply panic (in debug mode!) when they are not escaped. Preference for the latter.
Do you want to provide a patch @blckngm?
Sorry, something went wrong.
Escaping them on encoding, writing one character at a time, shouldn't have much performance penalty as long as the writer is buffered.
Fine with escaping one character at a time as long as we have an accompanying benchmark that proves that this is not a performance bottleneck.
No branches or pull requests
Shouldn't help strings and label values be escaped?
https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#escaping
The text was updated successfully, but these errors were encountered: