Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize memory metric names #869

Closed
SuperQ opened this issue Mar 27, 2018 · 5 comments
Closed

Standardize memory metric names #869

SuperQ opened this issue Mar 27, 2018 · 5 comments

Comments

@SuperQ
Copy link
Member

SuperQ commented Mar 27, 2018

In order to compare memory metrics cross-platform, some of the metrics need to be renamed where they are appropriately comparable.

Some candidates that seem to match on all platforms:

node_memory_bytes_total
node_memory_free_bytes_total
@brian-brazil
Copy link
Contributor

I'm not sure this is sensible, to be comparable and thus to have the same name they should have exactly the same meaning and I'm betting that's not the case for even those two metrics on the platforms we support.

@discordianfish
Copy link
Member

Tried that, was quite painful. For reference: #233

@stuvie
Copy link
Contributor

stuvie commented Mar 28, 2018

standardizing the metrics will allow us to have cross-platform grafana dashboards

@SuperQ
Copy link
Member Author

SuperQ commented Mar 28, 2018

@stuvie The problem is that cross-platform dashboards are likely to generate incorrect results.

For Grafana, cross-platform views can be generated by having multiple queries in a single graph that return the correct results based on the platform in question.

@SuperQ
Copy link
Member Author

SuperQ commented May 2, 2018

Since we've decided that it's not really comparable between platforms, I will close this.

@SuperQ SuperQ closed this as completed May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants