-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky TestAsyncRuleEvaluation #13547
Comments
I think creating more rules for evaluation in |
I haven't looked at the test at all. |
TIL about windows timer resolution being ~15ms! My hypothesis is that the concurrency does not get to "kick in" with just 6 rules, and so if we increase the number of rules to evaluate, the time savings due to concurrency will get more marked. check #13553 |
I just got this on my desktop Linux VM:
|
Huh, that test is flakey too? I think the same technique will help there as well. Updated |
Flaked on https://github.com/prometheus/prometheus/actions/runs/8080900355/job/22078272296?pr=13662 (windows)
and
|
Looking at the code again, it seems to rely on a 10ms prometheus/rules/manager_test.go Line 2075 in 3b8b577
prometheus/rules/manager_test.go Line 1926 in 3b8b577
This assumption is not safe: golang/go#44343 (but will be safer in Go 1.23). The timings in flake reports above don't match neatly to the 15ms value on Windows, so I guess something else is going wrong. |
Another example: https://github.com/prometheus/prometheus/actions/runs/9076113775/job/24938133905?pr=14098#step:4:13802
|
Unfortunately we're still seeing this on
|
#14300 was merged for this. |
Failed here: https://github.com/prometheus/prometheus/actions/runs/7797756253/job/21265037848?pr=13545
Passed on re-run: https://github.com/prometheus/prometheus/actions/runs/7797756253/job/21265977651?pr=13545
Also failed here: https://github.com/prometheus/prometheus/actions/runs/7725797136/job/21060788152?pr=13197
The text was updated successfully, but these errors were encountered: