Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use humanizeDuration from prometheus/common #14198

Closed
freak12techno opened this issue Jun 3, 2024 · 1 comment · Fixed by #14202
Closed

Use humanizeDuration from prometheus/common #14198

freak12techno opened this issue Jun 3, 2024 · 1 comment · Fixed by #14202
Assignees
@freak12techno

Comments

@freak12techno
Copy link
Contributor

freak12techno commented Jun 3, 2024 •
edited
Loading

Proposal

Since I've added humanizeDuration to prometheus/common in order to reuse it in Alertmanager (prometheus/common#627), makes sense to remove it from Prometheus repo and use the common implementation of it.

Will create a PR after making the similar one on Alertmanager. (Can't assign myself though.)
@machine424
Copy link
Collaborator

Done, thanks.

@freak12techno freak12techno mentioned this issue Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freak12techno freak12techno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use HumanizeDuration from prometheus/common freak12techno/prometheus
2 participants
@machine424 @freak12techno