-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s/walk:/bulkget:/ in snmp.yml #29
Comments
"Walk" is not a SNMP command, and with #8 we'll not only use bulkget. I don't think it'd be reasonable to require a user to rename a part of their config based on which protocol is being used, nor to have a misleading name for it. |
If you think it's misleading that's fine. That being said, I do think that deprecating old syntax for correct names is valid as it's beneficial in the long term. |
@SuperQ The planned breaking release in snmp_exporter allows us to reconsider it. I normally wouldn't re-open, but as we're breaking ALL the things anyway, this can serve as a useful canary if anyone loads an old config. This might even allow us to resolve #619 by removing support for |
The snmp_exporter does not walk, it bulkgets. That's something I had to point out several times in internal discussions.
Supporting the old
walk:
while throwing a deprecation warning would be a viable upgrade path.The text was updated successfully, but these errors were encountered: