Change payment method / mandate description

[remcotolsma]

We have added support for the WooCommerce Subscriptions payment method change feature:

wp-pronamic-pay-woocommerce/src/Gateway.php

Lines 432 to 470 in 49f7c07

	// Set Mollie sequence type on payment method change.
	if ( \did_action( 'woocommerce_subscription_change_payment_method_via_pay_shortcode' ) ) {
	$payment->set_meta( 'mollie_sequence_type', 'first' );
	/**
	* Use payment method minimum amount for verification payment.
	*
	* @link https://help.mollie.com/hc/en-us/articles/115000667365-What-are-the-minimum-and-maximum-amounts-per-payment-method-
	* @link https://github.com/pronamic/wp-pronamic-pay-woocommerce/issues/51
	*/
	$total_amount = $payment->get_total_amount();
	if ( $total_amount->is_zero() ) {
	switch ( $payment->get_payment_method() ) {
	case PaymentMethods::BANCONTACT:
	case PaymentMethods::DIRECT_DEBIT_BANCONTACT:
	$amount = 0.02;
	break;
	case PaymentMethods::DIRECT_DEBIT_SOFORT:
	case PaymentMethods::SOFORT:
	$amount = 0.10;
	break;
	case PaymentMethods::APPLE_PAY:
	case PaymentMethods::CREDIT_CARD:
	case PaymentMethods::PAYPAL:
	$amount = 0.00;
	break;
	default:
	$amount = 0.01;
	}
	$total_amount = new Money( $amount, $total_amount->get_currency() );
	$payment->set_total_amount( $total_amount );
	}
	}

Currently the Mollie payment description is something like "Order #1359":

This is confusing when entering the payment into an accounting program, because it is not in fact a payment for an order. There is usually no invoice available for these micro payments. It would be nicer/better if it said something like "change payment method for order X" or something like that. In addition, the customer pays € 0.01, but the transaction costs € 0.29. The current minimum amounts are fixed in the code, but it might be desirable to make this adjustable?

CC @rvdsteege

[rvdsteege]

Would "change payment method for order X" be a fixed text as in Payment method change for {subscription_description} or configurable (if so, how/where?). I think fixed is fine in this case (decisions, not options).

In addition, the customer pays € 0.01, but the transaction costs € 0.29. The current minimum amounts are fixed in the code, but it might be desirable to make this adjustable?

Hmm, wouldn't it be kind of strange if customers are charged for changing their payment method? The € 0,01 is out of necessity. Such a setting would apply for all payment methods regardless of their minimum amount, so for example an advanced setting 'Subscription payment method update amount' or could this be a filter (we will then need to use the highest of the payment method minimum amount and the filtered amount)?