Make demo repos usable when ALLOW_WIP is False
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several issues:
* RepoLoader
- Was calling `self.check_wip_mode()` even for demo repos, which it should not do.
- Needed the demo username to be available in a simulated `session` during async processing.
* SourceLoader
- Had a redundant `self.confirm()`, which we now remove entirely. The `self.check_permissions()`
method already performs exactly the required check.
* WriteHandler
- Like the `RepoLoader`, needed the demo username to be available in a simulated `session`
during async processing.
As part of this fix, we now provide the facility to set a simulated session for async processing.
skieffer
force-pushed
the
demos-sans-wip
branch
from
b32169e to
389867b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
There were several issues:
self.check_wip_mode()even for demo repos, which it should not do.sessionduring async processing.self.confirm(), which we now remove entirely. Theself.check_permissions()method already performs exactly the required check.
RepoLoader, needed the demo username to be available in a simulatedsessionduring async processing.
As part of this fix, we now provide the facility to set a simulated session for async processing.