Add vers nums to certain URLs #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now add to the served state the URL from which (our fork of ) pdfjs should be loaded, and this includes a version number, based on a new config var, `PDFJS_VERSION`.
The pfsc-server project defines a few "native" static files, under its `static` dir. (A lot of other static files are linked into a working deployment, from other projects.) We now include pfsc-server's version number in the URLs for these native static files.
skieffer
added
the
breaking
This PR includes breaking changes, so should signal a "major" increment (minor place for now, since major is zero).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the need for cache busting for
pfsc-pdf, as well as forpfsc-server's native static files, by adding version numbers to the URLs for these resources.Breaking changes
pfsc-manage: the MCA deployment will have to adapt to the new URLs for the native static assetsOther changes
The URL for pdfjs is now a part of the served state.
pfsc-iseshould now use this to loadviewer.htmlin pdf panels.