D.R.Y. with version numbers #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under this new system, we leave it to the client-side code to insert the actual version number for each project, replacing the string "VERSION". This means the server does not need to know these numbers, and we do not have to repeat ourselves.
We fix a value of "0.0" so that unit tests can run even when no ISE_VERSION has been set.
skieffer
added
the
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had a D.R.Y. problem with the version numbers for certain JS dependencies.
This and companion PRs in the other projects make it so these numbers are set only in
pfsc-ise,and no longer appear as config vars in
pfsc-serverandpfsc-manage.