Replace setoptconf

[carlio]

setoptconf is used for loading configuration values but is an old, stale library; #438 shows that it needs to be updated, or an alternative found.\

(for now a temporary solution is in place)

This issue is here as a placeholder for work done to properly replace it with another library (or alternatively take on maintaining setoptconf completely but... I really don't want to do that).

(ping @jayclassless )

[jayclassless]

Oh wow -- a blast from the past. :)

If you send over a PR with the fixes you made, I'd be happy to merge them and publish an update to PyPI to hold you over until you're able to completely replace it.

[graingert]

@jayclassless thanks I made a PR jayclassless/setoptconf#3

[jayclassless]

@jayclassless thanks I made a PR jayclassless/setoptconf#3

Merged and published as 0.3.0.

[graingert]

@jayclassless nice, can you also upload a wheel so nobody will be impacted by future setuptools changes?

[jayclassless]

Yup, good call. Uploaded.

[sbrunner]

Shouldn't we use pydentic?
https://realpython.com/python-pydantic/

[carlio]

Correct me if I'm wrong, but pydantic will not do the command line argument parsing as well? It's not simply about reading the .prospectorrc config files, but having a unified way to also handle prospector --some-arg where some-arg could also be in a config file. I started looking into Click for this and ran into the same issue but the other way round, not sure if I investigated either option enough though.

[sbrunner]

Effectively, I completely missed this part... but after a small search I see that there is a project that does that:
https://pypi.org/project/argparse-pydantic/
I'd like to start a test with that :-)

[carlio]

That looks pretty neat, it's worth trying.

One concern though - just looking at the README, it gives the example of arg_int which is turned into the CLI option --arg_int, while prospector has flags like --absolute-paths. As long as there's a way to keep the hyphens instead of underscores for CLI usage, then great, because people won't have to change their CI scripts. However you obviously can't have a Python class member called absolute-paths

[sbrunner]

+1 This is an important point, this should be solved :-)

[carlio]

Oh it might have been - https://github.com/ayasyrev/argparse_pydantic/blob/main/examples/example_05_pydocs.py#L17