Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] discourage frosted #501

Open
a-takahashi223 opened this issue Mar 24, 2022 · 4 comments
Open

[FEATURE REQUEST] discourage frosted #501

a-takahashi223 opened this issue Mar 24, 2022 · 4 comments

Comments

@a-takahashi223
Copy link

Is your feature request related to a problem? Please describe.
frosted does not work with python 3.10.
That's natural because frosted is deprecated for some years.
But when you install prospector[with_everything], frosted will be installed. Then if you run prospector -w frosted, you will get errors.
Thus with_everything is discouraged.

Describe the solution you'd like
Where with_everything is introduced in the documentation, annotate to recommend with_pyroma,with_vulture,with_mypy,with_bandit instead as frosted is deprecated.

Describe alternatives you've considered
Stop supporting frosted.
This is not good because backward compatibility will be broken.

@Pierre-Sassoulas
Copy link
Collaborator

- frosted = {version = ">=1.4.1", optional = true}
+ frosted = {version = ">=1.4.1;python_version<"3.10"", optional = true}

Could works, right ?

@a-takahashi223
Copy link
Author

Oh, sorry. I seem to have missed the point.
frosted is deprecated and should not be used in new projects.
I am suggesting we tell that in the documentation.

@carlio
Copy link
Contributor

carlio commented Mar 24, 2022

Yes, I already have plans to remove frosted in versions 2+ and to add deprecation warnings starting with 1.8

In the meantime, I will be able to add the additional python version filter (as @Pierre-Sassoulas suggested) along with explicit documentation that frosted will not work in 3.10, and since those are optional tools it's possible to continue running even with prospector -w frosted but emit an error/warning.

Frosted is definitely going to be removed, I just need to do it carefully to be backwards compatible.

@a-takahashi223
Copy link
Author

Nice.
I tested only 3.10, so frosted may not work in also 3.9 or older.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants