-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better comment parse #1419
feat: better comment parse #1419
Conversation
recih
commented
Jun 9, 2020
- fix trailing comment in last line can be recognized as leading comment for current field by mistake.
- new preferTrailingComment option in IParseOptions, user can choose the priority of trailing comments and leading commnets
- test updated.
Can you explain a bit more what the incorrect previous behavior was and how your fix changes it? |
when there is no extra new line between two fields, you will get after my fix, you will get:
also there is an option
|
@murgatroid99 will you review my PR, please ❤️ |
* fix trailing comment in last line recognized as leading comment for current token. * add preferTrailingComment to IParseOptions Co-authored-by: Alexander Fenster <fenster@google.com>