Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not fail if no process #1440

Merged
merged 1 commit into from
Jul 13, 2020
Merged

fix: do not fail if no process #1440

merged 1 commit into from
Jul 13, 2020

Conversation

alexander-fenster
Copy link
Contributor

The problem was introduced in #1363.

$ npm run make
...
ReferenceError: process is not defined
    at Object.r.39.1 (evalmachine.<anonymous>:7:64076)
    at t (evalmachine.<anonymous>:7:73046)
    at Object.r.42.39 (evalmachine.<anonymous>:7:69283)
    at t (evalmachine.<anonymous>:7:73046)
    at Object.r.18.27 (evalmachine.<anonymous>:7:23855)
    at t (evalmachine.<anonymous>:7:73046)
    at Object.r.17.12 (evalmachine.<anonymous>:7:23036)
    at t (evalmachine.<anonymous>:7:73046)
    at Object.r.19.11 (evalmachine.<anonymous>:7:24055)
    at t (evalmachine.<anonymous>:7:73046)

Let's make sure we actually have process before accessing it.

@alexander-fenster alexander-fenster merged commit f2faa8c into master Jul 13, 2020
@dcodeIO dcodeIO mentioned this pull request Jul 13, 2020
Merged
taylorcode pushed a commit to taylorcode/protobuf.js that referenced this pull request Oct 16, 2020
@alexander-fenster @taylorcode
fix: do not fail if no process (protobufjs#1440)
6c33b8d
@dcodeIO dcodeIO deleted the typeof-process branch April 7, 2022 04:34
This was referenced May 20, 2022
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jul 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@bcoe bcoe Awaiting requested review from bcoe

@murgatroid99 murgatroid99 Awaiting requested review from murgatroid99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-fenster @JustinBeckwith