Treat absolute paths as relative

[ddimitrioglo]

protobuf.js version: 7.2.0

We have a package @packaly/core-sdk package where we store all the proto files and generated files.
After the last dependencies reinstallation, seems that the path resolution got broken.
After investigation, I could drill down to protobufjs which is an indirect dependency for our package.

The structure:

├── package.json
└── packaly
    ├── backend
    │   └── v1
    │        ...
    │       ├── store.pb.js
    │       ├── store.pb.ts
    │       └── store.proto
    ├── common
    │    ...
    │   ├── geo.pb.js
    │   ├── geo.pb.ts
    │   └── geo.proto
    ...

The store.proto

syntax = "proto3";

package packaly.backend.v1;

import "packaly/common/geo.proto"; // <== THIS import fails

service StoreService {
  // some rpcs here
}

with version 7.2.0 (which is installed automatically via the dependency tree) I get the following error:

ENOENT: no such file or directory, open '/MY-PROJECT/node_modules/@packaly/core-sdk/packaly/backend/v1/packaly/common/geo.proto'
Error: The invalid .proto definition (file not found)

when I update my package.json with "protobufjs": "7.1.2" everything works as expected.

[alexander-fenster]

I also see this problem, I'll see which change breaks the world and will fix / revert.

[alexander-fenster]

v7.2.1 should fix it.

[ddimitrioglo]

✅ confirm!

Thanks for the quick fix!

[alexander-fenster]

I actually suspect that if your code failed on v7.2.0, it might mean that the imports in your protos might actually be wrong, and the fix I reverted just made the loading code fail loudly where it previously accepted the wrong inputs. It does not justify the breaking change – hence I reverted #1817 – but it might signal that your protos are non compliant. Mine definitely were: I had an incorrect relative path in the import directive. So, if you were affected by this, it's worth checking your imports :)

[ddimitrioglo]

@alexander-fenster I've posted the structure and import above, so if you see any issues I'd be more than happy to fix them if you provide any hints on how to do that...

P.S. Currently, I'm using buf lint to validate protos and generate the code and it passes validation with my existing structure.