Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

copy-workflow fails if repo uses submodules #248

Closed
galargh opened this issue Dec 10, 2021 · 3 comments
Closed

copy-workflow fails if repo uses submodules #248

galargh opened this issue Dec 10, 2021 · 3 comments

Comments

@galargh
Copy link
Contributor

galargh commented Dec 10, 2021

https://github.com/filecoin-project/go-commp-utils uses https://github.com/filecoin-project/filecoin-ffi as a submodule. The latter defines go1.13 in it's go.mod file. When we try to copy workflows for go-commp-utils, we also try to update go version in the submodule which fails: https://github.com/protocol/.github/runs/4485167112?check_suite_focus=true

We could temporarily fix it by adding filecoin-ffi to unified CI framework (which we should) but it won't stop the issue from reappearing during go upgrades for example.

@marten-seemann
Copy link
Contributor

I think @mvdan had some thoughts about this, but I think that was somewhere on Slack and not on an issue here.

@mvdan
Copy link
Contributor

mvdan commented Dec 19, 2021

The way many modules require filecoin-ffi today is quite broken; see filecoin-project/filecoin-ffi#209. This is what leads to the git submodule and the replace directive, and the manual steps required to build the parent Go module.

I think we should focus on making filecoin-ffi easy to use as a Go module (see the link above), rather than adding ways to work around the problems it causes today :)

@galargh
Copy link
Contributor Author

galargh commented Aug 28, 2023

The initial issue - updating go.mod in submodules - has been resolved by updating only those go.mod files that are committed - ipdxco/unified-github-workflows@ddcf7dc.

@galargh galargh closed this as completed Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants