[FilRPC Audit] Lotus

[rvagg]

(Edit this post to add more items, or simply add them in comments in the same format)

• doc: Clarify documentation wrt ListenAddress (ref)
• FURTHER INVESTIGATION: Is there a consistent logic to client/token permissions? It appears inconsistent. (ref)
  • doc: Clarify Lotus cmdline output and/or docs regarding how/when read tokens are needed (ref)
• cli: Improve cmdline instructions and/or error output (or fix?) commP and generate-car commands when supplying a file (ref)
• FURTHER INVESTIGATION: Is it possible to clean up file imports after deal-making (cli & API)? (ref)
• doc: API docs "Inputs" don't document types, just examples, some are not obvious (ref)
• api: ClientQueryAsk requires both minerAddress and peerId, but cli makes peerId optional and will find it in state if you don't supply it - offer the same abilities to the API? (ref)
• api: At scale, the API can cause a miner to lose sync, worth noting in any user-focused docs (ref)

[vasco-santos]

filecoin-project/lotus#5814 is a first step towards Is there a consistent logic to client/token permissions? It appears inconsistent.. I asked feedback of the team on follow up options