Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not disable RTTI by default in the CMake build #8377

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Do not disable RTTI by default in the CMake build #8377

merged 1 commit into from
Mar 4, 2021

Conversation

floriansimon1
Copy link

This is supposed to be optional, not enabled by default.

@dkorchynskyi-axcient: as promised

@acozzette we might want to merge this sooner rather than later.

@floriansimon1
Copy link
Author

There's also a version that is mergeable to the master branch.

Copy link

@dkorchynskyi-axcient dkorchynskyi-axcient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@acozzette acozzette merged commit b9a036b into protocolbuffers:3.15.x Mar 4, 2021
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants