-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proto_api.h not included in python packages #9464
Comments
The new Python Proto library cannot support the existing We will likely expose a new/different capsule eventually to allow pybind11 users to access the upb proto object. But this will not be in the first version. |
What implications does this have for creating python bindings to a C++ library using the C++ protobuf library and not upb? It sounds like it will require serialization/deseralization to transform c++ message instances into python upb instances. That would be very unfortunate for us and would bring us back to the current state, which we had hoped to improve by using |
@haberman - do you have any way forward for making pybind11_protobuf buildable again? Something that is available now, not "eventually"? As long as you don't have a replacement, you should not break dependent projects. |
I believe the pybind11_protobuf build should be fixed by: pybind/pybind11_protobuf#165 |
What version of protobuf and what language are you using?
Version: master/3.19/3.14, seems to affect all recent versions
Language: C++/Python
What operating system (Linux, Windows, ...) and version?
Linux
What runtime / compiler are you using (e.g., python version or gcc version)
Not really applicable
What did you do?
Trying to compile a python extension using pybind11_protobuf, the Header proto_api.h, which is inside the python package in this repo is not found.
It seems this header is not included when installing the python package, e.g. in wheels or the arch linux python-protobuf package.
What did you expect to see
Header is included.
What did you see instead?
See above.
The text was updated successfully, but these errors were encountered: